Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agw] Replace hashtable OAI lib to a standard library through map.h interface #11190

Open
Tracked by #11199
ardzoht opened this issue Jan 18, 2022 · 3 comments
Open
Tracked by #11199
Assignees
Labels
cpp-migration C++ migration-related issue willfix This will be worked on and shouldn't be reaped

Comments

@ardzoht
Copy link
Contributor

ardzoht commented Jan 18, 2022

Description

  • OAI makes use of its own internal library for hashtable structures. This is a wide-used library being used throughout all MME tasks mostly for the maintenance of both task’s and UE state. There are multiple types available to use, but mostly both uint64 => uint64 and uint64 => object PTR thread-safe mappings are the most used in the codebase.
  • This library has shown evidence of being prone to instability across compiler versions, due to its complex memory management with value and key pointer objects: e.g. fix(mme): Fix to pass test_ngap_state_converter in Bazel testing #11865

Goal

  • We want to iteratively migrate OAI’s hashtable and their usage to protobuf's generated object CPP hashmap structs, a starting point to refer can be: /lte/gateway/c/core/oai/tasks/mme_app/mme_app_ip_imsi.cpp or lte/gateway/c/core/oai/include/map.h
  1. Replace hashtable lib usages in S1AP, NGAP task procedures to magma::map_s
  2. Replace hashtable lib usages in SPGW task procedures to magma::map_s
  3. Replace hashtable lib usages in MME APP task procedures to magma::map_s
  4. Replace hashtable lib usages in SGW_S8 task procedures to magma::map_s
@ssanadhya
Copy link
Collaborator

@rsarwad , is there any hash table managed by the SGW_S8 task? If yes, please add that to the list of goals for this issue.

@rsarwad
Copy link
Contributor

rsarwad commented Apr 6, 2022

Yes @ssanadhya, SGW_S8 task also includes hash tables. The estimation includes sgw_s8 task

@stale
Copy link

stale bot commented Jul 5, 2022

This issue or pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs in the next 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp-migration C++ migration-related issue willfix This will be worked on and shouldn't be reaped
Projects
Status: In Progress
Development

No branches or pull requests

3 participants