Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datapath: Refactor ARP handling from inout app #12071

Closed
pshelar opened this issue Mar 10, 2022 · 2 comments · Fixed by #12566
Closed

datapath: Refactor ARP handling from inout app #12071

pshelar opened this issue Mar 10, 2022 · 2 comments · Fixed by #12566
Assignees
Labels

Comments

@pshelar
Copy link
Contributor

pshelar commented Mar 10, 2022

Create separate module to handle ARP handling
verification:
Run unit test and integ test after rector is done.

@sebathomas
Copy link
Contributor

@pshelar Can you give a few more details about this task? Which ARP handling should be extracted to a separate module?

Is it about the ArpController or ARP handling in one of the other parts of pipelined? It might also be related to #12495, I see there are some reference to ARP in the new EgressController.

@pshelar
Copy link
Contributor Author

pshelar commented Apr 25, 2022

I am referring to ARP probes : _get_gw_mac_address_v4(), _get_gw_mac_address_v6(), etc:

def _get_gw_mac_address_v4(self, ip: IPAddress, vlan: str = "") -> str:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants