Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dpi code from pipelined #12076

Open
koolzz opened this issue Mar 10, 2022 · 2 comments
Open

Remove unused dpi code from pipelined #12076

koolzz opened this issue Mar 10, 2022 · 2 comments
Labels
good first issue Good for newcomers willfix This will be worked on and shouldn't be reaped

Comments

@koolzz
Copy link
Contributor

koolzz commented Mar 10, 2022 •
edited

We need to remove DPI

The main things to remove:

  • dpi.py
  • service_manager.py dpi references
  • all dpi related tests (after the above service manager changes a lot of tests that had DPI as a forward table might need to have their snapshots updated)
  • dpi rpc calls in rpc_handler.py
  • dpi register in registers.py
  • dpi references in docs

After changing everything make sure to run the python test suite with make test_python
@koolzz koolzz added the good first issue Good for newcomers label Mar 10, 2022
@ekowtaylor ekowtaylor added the willfix This will be worked on and shouldn't be reaped label Mar 14, 2022
@spikey979 spikey979 mentioned this issue Mar 21, 2022
Closed
@geetikabatra
Copy link
Contributor

@vikramgreddy Are you still working on this one?

@ssanadhya
Copy link
Collaborator

@vikramgreddy , can you confirm if you are working on this?

@nstng nstng assigned nstng and unassigned vikramgreddy Dec 28, 2022
@nstng nstng mentioned this issue Dec 28, 2022
Closed
1 task
@nstng nstng removed their assignment Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers willfix This will be worked on and shouldn't be reaped
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: dpi is removed from pipelined nstng/magma
6 participants
@ssanadhya @ekowtaylor @geetikabatra @koolzz @nstng @vikramgreddy