Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis: Can bazel-built proto sources be used for the envoy_controller? #13521

Open
LKreutzer opened this issue Aug 5, 2022 · 0 comments
Open

Analysis: Can bazel-built proto sources be used for the envoy_controller? #13521

LKreutzer opened this issue Aug 5, 2022 · 0 comments
Labels
bazel changes for the Bazelification effort willfix This will be worked on and shouldn't be reaped

Comments

@LKreutzer
Copy link
Contributor

LKreutzer commented Aug 5, 2022 •
edited

Analysis task:

  • Can bazel-built proto sources be used for the envoy_controller service?
  • Currently we are using the pre-compiled and checked in .pb.go files.
  • Can we instead generate go_proto libraries directly with Bazel from the .proto files and use these?
  • Issue: The bazel-built go proto code seems to be somewhat different from the checked in code.
    • Does the checked in code need to be updated?
    • Are the differences relevant?
    • Why is the go proto code checked in at all?
@LKreutzer LKreutzer added bazel changes for the Bazelification effort willfix This will be worked on and shouldn't be reaped labels Aug 5, 2022
@LKreutzer LKreutzer mentioned this issue Aug 5, 2022
Merged
1 task
@mpfirrmann mpfirrmann mentioned this issue Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bazel changes for the Bazelification effort willfix This will be worked on and shouldn't be reaped
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LKreutzer