Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf/grpc uses pre-build binaries #13850

Open
nstng opened this issue Sep 6, 2022 · 5 comments
Open

protobuf/grpc uses pre-build binaries #13850

nstng opened this issue Sep 6, 2022 · 5 comments
Labels
bazel changes for the Bazelification effort willfix This will be worked on and shouldn't be reaped

Comments

@nstng
Copy link
Contributor

nstng commented Sep 6, 2022

A fresh (cache-less) bazel build takes a long time to compile protobuf/grpc libraries. See rules-proto-grpc/rules_proto_grpc#165 for a workaround.

  • try the workaround in Slow compiling every time? rules-proto-grpc/rules_proto_grpc#165 (comment) and evaluate if this improves the current state
  • also needs to work with arm
  • needs to work with remote caches
  • if the workaround improves the current state then implement it and ...
    • track this sufficiently with a TODOGH12345 and an open issue - this should be removed if it is solved upstream
@nstng
Copy link
Contributor Author

nstng commented Sep 6, 2022

team unsure for now if this workaround is a good idea - will be kept in backlog for now

@jheidbrink
Copy link
Contributor

The speed of fresh bazel build's is also a subject of #13362 - having more remote cache hits might amend this problem.

1 similar comment
@jheidbrink
Copy link
Contributor

The speed of fresh bazel build's is also a subject of #13362 - having more remote cache hits might amend this problem.

@LKreutzer LKreutzer added the willfix This will be worked on and shouldn't be reaped label Nov 9, 2022
@sebathomas sebathomas changed the title potobuf/grpc uses pre-build binaries protobuf/grpc uses pre-build binaries Nov 15, 2022
@nstng nstng self-assigned this Nov 22, 2022
@nstng nstng removed their assignment Dec 5, 2022
@nstng
Copy link
Contributor Author

nstng commented Jan 30, 2023

I tried the workarounds in the mentioned issue in the description - but could not make it work. Maybe it can be tried again with a longer timebox.

@LKreutzer
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort willfix This will be worked on and shouldn't be reaped
Projects
None yet
Development

No branches or pull requests

3 participants