Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up pinning of golang.org/x/tools v0.1.12 #14248

Closed
LKreutzer opened this issue Oct 24, 2022 · 0 comments · Fixed by #14941
Closed

Clean up pinning of golang.org/x/tools v0.1.12 #14248

LKreutzer opened this issue Oct 24, 2022 · 0 comments · Fixed by #14941
Assignees
@wolfseb
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) containerization Changes for more docker usage willfix This will be worked on and shouldn't be reaped

Comments

@LKreutzer
Copy link
Contributor

See: PR #14245
Slack: https://magmacore.slack.com/archives/C01AWMH0EJW/p1666616733527639

Option 1: Clean up pinning and make newer version work.
Option 2: Add comment to explain pinning and create task to review the pinning when newer versions are released.
@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) containerization Changes for more docker usage willfix This will be worked on and shouldn't be reaped labels Oct 24, 2022
@wolfseb wolfseb self-assigned this Feb 2, 2023
@wolfseb wolfseb mentioned this issue Feb 2, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfseb wolfseb

Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) containerization Changes for more docker usage willfix This will be worked on and shouldn't be reaped
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(feg): remove pinning of golang.org/x/tools wolfseb/magma
2 participants
@LKreutzer @wolfseb