Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test duplication in feg radius #14349

Closed
wolfseb opened this issue Nov 3, 2022 · 0 comments · Fixed by #14917
Closed

Remove test duplication in feg radius #14349

wolfseb opened this issue Nov 3, 2022 · 0 comments · Fixed by #14917
Assignees
@MoritzThomasHuebner @wolfseb
Labels
component: feg FEG-gateway related issues

Comments

@wolfseb
Copy link
Contributor

wolfseb commented Nov 3, 2022

Summary

There are two tests in feg/radius/src/modules/lbserve (TestLBServeFailsWithRadiusError and TestLBServeProxiesRequestToRadiusAndReturnsResponse) which are exact copies of each other, while the names suggest that they should test opposite behaviors. Either remove the duplication or fix TestLBServeFailsWithRadiusError so it tests what it is supposed to test.

Hint: it is probably enough to change the function spawnFailingRadiusServer to spawn a failing Radius server and then change the asserts accordingly.
@wolfseb wolfseb added the component: feg FEG-gateway related issues label Nov 3, 2022
@sebathomas sebathomas changed the title Remove test dublication in feg radius Remove test duplication in feg radius Dec 22, 2022
@wolfseb wolfseb linked a pull request Jan 31, 2023 that will close this issue
test(cwg): Remove duplicate Radius test #14917
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MoritzThomasHuebner MoritzThomasHuebner

@wolfseb wolfseb

Labels
component: feg FEG-gateway related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(cwg): Remove duplicate Radius test MoritzThomasHuebner/magma
2 participants
@MoritzThomasHuebner @wolfseb