Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-only dependencies in the devcontainer are removed #14359

Open
nstng opened this issue Nov 4, 2022 · 1 comment
Open

make-only dependencies in the devcontainer are removed #14359

nstng opened this issue Nov 4, 2022 · 1 comment
Labels
bazel changes for the Bazelification effort bazel-cleanup BE fixups that came out of the Bazelification effort willfix This will be worked on and shouldn't be reaped

Comments

@nstng
Copy link
Contributor

nstng commented Nov 4, 2022 •
edited

To be groomed: is the devcontainer at the end only in thin wrapper around bazel base for vscode integration?
@LKreutzer LKreutzer added the willfix This will be worked on and shouldn't be reaped label Nov 9, 2022
@mpfirrmann mpfirrmann mentioned this issue Feb 28, 2023
Closed
@mpfirrmann
Copy link
Contributor

mpfirrmann commented Mar 2, 2023 •
edited

Basic idea:
Take the devcontainer dockerfile in https://github.com/magma/magma/blob/master/.devcontainer/Dockerfile and see if (apt-) packages / dependencies could be removed. Maybe we already install most of the important dependencies via bazel.
Test it with bazel-build-all, formatting, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bazel changes for the Bazelification effort bazel-cleanup BE fixups that came out of the Bazelification effort willfix This will be worked on and shouldn't be reaped
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpfirrmann @LKreutzer @nstng