Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Python precommit Docker setup #15000

Closed
LKreutzer opened this issue Feb 13, 2023 · 0 comments · Fixed by #15038
Closed

Refactor Python precommit Docker setup #15000

LKreutzer opened this issue Feb 13, 2023 · 0 comments · Fixed by #15038
Assignees
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) python Pull requests that update Python code tech-debt Clean up old/unused code, fix compiler warnings, align coding style, etc

Comments

@LKreutzer
Copy link
Contributor

LKreutzer commented Feb 13, 2023

Currently we build the Python precommit Docker image in CI in two workflows:

  • .github/workflows/docker-builder-python-precommit.yml
  • .github/workflows/python-workflow.yml

but never download it in CI, but only for local development.

  • Is the upload actually needed?
  • Should local usage also use a local build?
    • This may include a refactoring of precommit.py to make the --local behaviour the default.
  • Should the .github/workflows/python-workflow.yml download the image instead of a local build?
  • The following folders should be excluded from the local/CI check:
    • bazel-bin, bazel-out folders etc.
    • build folders
    • hil_testing
    • fabfile.py
    • setup.py

See: #14994

@LKreutzer LKreutzer added tech-debt Clean up old/unused code, fix compiler warnings, align coding style, etc python Pull requests that update Python code labels Feb 13, 2023
@LKreutzer LKreutzer added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Feb 13, 2023
@wolfseb wolfseb self-assigned this Feb 22, 2023
@wolfseb wolfseb linked a pull request Feb 22, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) python Pull requests that update Python code tech-debt Clean up old/unused code, fix compiler warnings, align coding style, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants