Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create deprecation warning for AGW Makefiles #15005

Closed
LKreutzer opened this issue Feb 14, 2023 · 0 comments · Fixed by #15007
Closed

Create deprecation warning for AGW Makefiles #15005

LKreutzer opened this issue Feb 14, 2023 · 0 comments · Fixed by #15007
Assignees
@LKreutzer
Labels
bazel changes for the Bazelification effort

Comments

@LKreutzer
Copy link
Contributor

The Make to Bazel switch-over for the AGW has been accepted by the TSC, see #14971. The Makefiles in the AGW should display a deprecation warning when used. This could be done either by adding comments inside the Makefiles or by printing a warning when executing commands or both. Only commands that will be deprecated should be affected.
@LKreutzer LKreutzer added the bazel changes for the Bazelification effort label Feb 14, 2023
@LKreutzer LKreutzer self-assigned this Feb 14, 2023
@LKreutzer LKreutzer mentioned this issue Feb 14, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LKreutzer LKreutzer

Labels
bazel changes for the Bazelification effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(agw): Add deprecation warnings to AGW Makefiles LKreutzer/magma
1 participant
@LKreutzer