Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bazel-built Python services in cwf/gateway/docker/python/Dockerfile #15041

Closed
LKreutzer opened this issue Feb 22, 2023 · 1 comment · Fixed by #15106
Closed

Use bazel-built Python services in cwf/gateway/docker/python/Dockerfile #15041

LKreutzer opened this issue Feb 22, 2023 · 1 comment · Fixed by #15106
Assignees
@LKreutzer
Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action)

Comments

@LKreutzer
Copy link
Contributor

LKreutzer commented Feb 22, 2023 •
edited

Use bazel-built (Python) services in cwf/gateway/docker/python/Dockerfile. This should make the Make Python environment/protos/swagger build unnecessary.

Relevant lines are:

  • cwf/gateway/docker/python/Dockerfile
    • COPY lte/gateway/python/defs.mk $MAGMA_ROOT/lte/gateway/python/defs.mk
    • COPY lte/gateway/python/Makefile $MAGMA_ROOT/lte/gateway/python/Makefile
    • RUN make -C $MAGMA_ROOT/orc8r/gateway/python protos

See also: #15034

  • The goal is to remove the need of all Make commands.
  • What workflows are impacted by this change?
@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) bazel changes for the Bazelification effort labels Feb 22, 2023
@LKreutzer LKreutzer mentioned this issue Feb 22, 2023
Closed
5 tasks
@LKreutzer
Copy link
Contributor Author

Relevant to #14835

@LKreutzer LKreutzer self-assigned this Feb 27, 2023
@LKreutzer LKreutzer mentioned this issue Mar 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LKreutzer LKreutzer

Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Build the Python services with Bazel for CWF Docker images magma/magma
1 participant
@LKreutzer