Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please gpg sign tags (and commits?) #152

Closed
thkoch2001 opened this issue Aug 20, 2015 · 6 comments
Closed

please gpg sign tags (and commits?) #152

thkoch2001 opened this issue Aug 20, 2015 · 6 comments
Assignees
Labels
admin Project/release administrativia
Milestone

Comments

@thkoch2001
Copy link

Hi,

could you please sign your git tags? Thus people can verify that they got the code you wrote and not some man-in-the-middle attack.

man git-tag

Thx!

@Fuco1
Copy link
Collaborator

Fuco1 commented Aug 20, 2015

Isn't comparing the hash enough?

@thkoch2001
Copy link
Author

what hash to compare with what? And how to trust the "what"?

@Fuco1
Copy link
Collaborator

Fuco1 commented Aug 20, 2015

And how would you trust/verify my signature, and those of all the contributors? Crypto is nice but breaks very fast in the real world under non-perfect assumptions.

I would trust github to not forge the hashes more than random guy from the internet sending you his key, if I were going for security.

I can happily sign the commits as it is no burden at all, but I find it pretty pointless, so I never bothered to set it up. Plus, unless all the contributors do so it's useless anyhow, so let's wait for the rest to say something.

@thkoch2001
Copy link
Author

I can trust your signature if your key is signed by people that are strongly connected to the web of trust. I've never met Richard Stallman, but there are 8 different trust paths from my key to his key:
http://pgp.cs.uu.nl/paths/042BA65A/to/2A8E4C02.html

I also don't need to trust all contributors. I believe that somebody who tags the release should be responsible to know the contributors and have reviewed patches or have other people who review those patches. Linus Torvalds does not review all patches to the linux kernel himself but he has people he trusts.

@stiell
Copy link

stiell commented Sep 27, 2016

Even a signature by an untrusted key is better than nothing. Unsigned code is open to any MITM attacker. If the repo has signed commits/tags, I can choose to trust on first use, after which pulling new code signed with the same key would be secure against a MITM attack.

It is not necessary that all commits are signed or that all keys are trusted. One could simply use the latest commit signed by a trusted key and then review any later untrusted changes as necessary before use.

@Fuco1 Fuco1 added the enhancement Suggestion to improve or extend existing behavior label Jul 26, 2018
@basil-conto basil-conto self-assigned this Jan 6, 2021
@basil-conto basil-conto added this to To Do in Release 2.18.0 Jan 6, 2021
@basil-conto basil-conto added this to the 2.18.0 milestone Jan 6, 2021
@basil-conto basil-conto added admin Project/release administrativia and removed enhancement Suggestion to improve or extend existing behavior labels Jan 6, 2021
@basil-conto basil-conto moved this from To Do to In Progress in Release 2.18.0 Feb 15, 2021
@basil-conto basil-conto moved this from In Progress to Done in Release 2.18.0 Feb 15, 2021
@basil-conto
Copy link
Collaborator

Please let me know if I did something incorrectly for the 2.18.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Project/release administrativia
Projects
No open projects
Development

No branches or pull requests

4 participants