Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dash--match public? #376

Open
okamsn opened this issue Mar 27, 2021 · 3 comments · May be fixed by #413
Open

Make dash--match public? #376

okamsn opened this issue Mar 27, 2021 · 3 comments · May be fixed by #413
Labels
enhancement Suggestion to improve or extend existing behavior
Milestone

Comments

@okamsn
Copy link

okamsn commented Mar 27, 2021

Hello,

I am writing a macro that can optionally use Dash for destructuring, and have been using dash--match to create a list of bindings suitable for using in a setq or let form. This has worked well.

Please consider making this function public, so that it can be depended on by other packages.

Thank you.

@basil-conto basil-conto added the enhancement Suggestion to improve or extend existing behavior label Mar 27, 2021
@basil-conto
Copy link
Collaborator

Sure, that would be nice. But I think these parts could use some cleanup before usefully being exposed.

In the meantime, have you tried using the built-in pcase/pcase-let/pcase-defmacro destructuring?

@okamsn
Copy link
Author

okamsn commented Mar 27, 2021

In the meantime, have you tried using the built-in pcase/pcase-let/pcase-defmacro destructuring?

Yes. Pcase and Dash have different ways of expressing destructuring, and a user requested that I support both. I see value in having both, and not duplicating the work Dash has already done.

I actually made a similar request to the authors of Pcase to make public Pcase's destructuring interface, which I am still testing.

@basil-conto
Copy link
Collaborator

I actually made a similar request to the authors of Pcase to make public Pcase's destructuring interface, which I am still testing.

Oh yes, I didn't recognise your name from that feature request: https://bugs.gnu.org/47261

@basil-conto basil-conto added this to To Do in Release 2.19.0 Mar 27, 2021
@basil-conto basil-conto added this to the 2.19.0 milestone Mar 27, 2021
@basil-conto basil-conto modified the milestones: 2.19.0, 2.20.0 Jun 29, 2021
@basil-conto basil-conto removed this from To Do in Release 2.19.0 Jun 29, 2021
@basil-conto basil-conto added this to To Do in Release 2.21.0 Jun 29, 2021
@okamsn okamsn linked a pull request Mar 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggestion to improve or extend existing behavior
Projects
Development

Successfully merging a pull request may close this issue.

2 participants