Ability to set server flood protection settings

[tecknojock]

Well, now that its officially included in the core, it'd be nice for the web server to be able to set this setting as well, if the core its connected to is late enough.

[magne4000]

Where is this new setting located ?

[tecknojock]

Here's the pull request that added it to the master: quassel/quassel#236

Unfortunately I havn't figured out how to cross compile a windows client so I'm waiting for the next release to be able to have access to the feature on the desktop.

[digitalcircuit]

Thanks for filing an issue here, @tecknojock!

Aside, for Windows you can probably use one of Quassel's AppVeyor builds - click on one that's not a pull request, go to msvc2015 64-bit or 32-bit depending, and download the installer from the Artifacts tab. Note that there's currently a bug where the Visual Studio 2013 Runtime is also required due to precompiled OpenSSL. @TheOneRing was still investigating it.

Eventually I intend to entirely rewrite Quassel's rate-limiting to follow what IRC servers actually do - limit according to bytes sent per unit of time. HexChat currently does this. That said, it's a risky change, other responsibilities mean I probably won't get to it soon, and I'll try to make changes as easy as possible to handle upgrading anyways, so...

In short, implementing what's currently in 0.13-git should be fine :)

Notable changes for rate limits

• Additional synced properties to Network object
  • Doxygen comments on properties
  • Protocol range enforcements
  • NOTE: don't allow setting setMessageRateDelay to 0, either. This is fixed in Quassel PR #252
  • Settings UI code, including enable checkbox, minimum/expected values
• Core Feature flag to detect if available: CustomRateLimits = 0x0080

[magne4000]

Thank you @digitalcircuit for all those details