Document title not updated when first selecting buffer

[digitalcircuit]

Issue

The call to set document.title here doesn't seem to apply when first connecting to Quassel Web and clicking a buffer. The title updates properly once a buffer is selected.

Steps

1. Connect to Quassel Web (reload page if needed)
2. Observe document title
3. Select a buffer

Expected

• Document title updates

Actual

• Document title stays as 'Quassel Web Server'
• The title gets correctly updated when choosing another buffer after first choosing one

I'll fill in more details later on if needed; not as much time right this moment

[magne4000]

Hum, I never had this behavior.

[digitalcircuit]

I can still reproduce this in Firefox 53 x64 on Ubuntu Linux 16.04 LTS, no modifications (tested using the Guest login). I have multiple networks configured.

Anything that'd be helpful to collect/test?

[ohnx]

I just tried this with quassel and Firefox 53.0.3 64bit running on Ubuntu 16.10, and didn't have any issue.

Perhaps a log of the console would help? (right click, inspect element, console)

Maybe an error is being thrown, causing the first update to not happen.

[digitalcircuit]

@ohnx Thank you for the suggestion; that pointed the issue!

16:40:56.062 Error: olfbuf is null
$scope.showBuffer@https://[domain_name]/chat/javascripts/angular-controller.js:346:17
fn@https://[domain_name]/chat/javascripts/angular.min.js line 237 > Function:4:223
e@https://[domain_name]/chat/javascripts/angular.min.js:282:195
$eval@https://[domain_name]/chat/javascripts/angular.min.js:147:309
$apply@https://[domain_name]/chat/javascripts/angular.min.js:148:12
compile/</<@https://[domain_name]/chat/javascripts/angular.min.js:282:245
dispatch@https://[domain_name]/chat/javascripts/jquery.min.js:3:10263
add/q.handle@https://[domain_name]/chat/javascripts/jquery.min.js:3:8325
 1 angular.min.js:122:8
	f/< https://[domain_name]/chat/javascripts/angular.min.js:122:8
	uf/this.$get</< https://[domain_name]/chat/javascripts/angular.min.js:94:42
	$apply https://[domain_name]/chat/javascripts/angular.min.js:148:59
	compile/</< https://[domain_name]/chat/javascripts/angular.min.js:282:245
	dispatch https://[domain_name]/chat/javascripts/jquery.min.js:3:10263
	add/q.handle https://[domain_name]/chat/javascripts/jquery.min.js:3:8325

Turns out enabling the Trim buffer when switching feature causes this to break; there's no check for if olfbuf is null.

When I disable Trim buffer when switching, first selection properly updates the window title.