Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Enable support for "return-empty" #5

Closed
wants to merge 2 commits into from

Conversation

geoffoxholm
Copy link

This small change adds support to get empty cells in the cell range.

@magnetikonline
Copy link
Owner

Hello @lafcadio - thanks for the PR.

I'll review this work and get it merged - when time allows!

Pete

@magnetikonline
Copy link
Owner

@lafcadio I'm curious to know - where did you find return-empty documented at the official Google API docs page? :)

@geoffoxholm
Copy link
Author

@magnetikonline - It's hinted at all over the place, but I agree, it's kind of illusive. Here's a link:
https://developers.google.com/gdata/javadoc/com/google/gdata/client/spreadsheet/CellQuery

@magnetikonline
Copy link
Owner

Thanks @lafcadio - champion, I'll add that to the README.md when I finally get around to merging (sorry, been a busy time in life!).

Pete

@geoffoxholm
Copy link
Author

No worries, @magnetikonline, thanks for your consideration.

@adriweb
Copy link

adriweb commented Aug 22, 2015

Note @lafcadio: There needs to be $value = $cellRangeCriteriaList[$key]; right before line 171 of the proposed patch.

@magnetikonline
Copy link
Owner

Thank @adriweb - I'll take that into consideration.

@geoffoxholm
Copy link
Author

Yeah, @adriweb is right. Whoops. Not sure how that happened. Thanks.

@magnetikonline
Copy link
Owner

magnetikonline commented Jul 7, 2017

Hey @geoffoxholm - finally getting around to some of these.... have committed your fine work as part of 58773de.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants