Skip to content

Commit

Permalink
Remove FIXME(s) (Don't scare Frank and magnum anymore)
Browse files Browse the repository at this point in the history
  • Loading branch information
ShaneQful authored and magnumripper committed Jan 26, 2013
1 parent 6bc9252 commit a7130d9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/ssh_ng_fmt_plug.c
Expand Up @@ -243,7 +243,7 @@ static int check_padding_3des(unsigned char *out, int length)

// now check padding
pad = out[length - 1];
if(pad > 16) /* FIXME: is this check valid? */
if(pad > 16) /* NOTE: is this check always valid? */
// "Bad padding byte. You probably have a wrong password"
return -1;
n = length - pad;
Expand Down Expand Up @@ -276,7 +276,8 @@ static int check_padding_3des(unsigned char *out, int length)
if (!res) {
goto bad;
}
/* FIXME: now this integer has to be big, is this always true? */
/* NOTE: now this integer has to be big, is this always true?
* RSA (as used in ssh) uses big prime numbers, so this check should be OK */
ul = strlen((char*)res);
p = res;
while(*p) {
Expand Down

0 comments on commit a7130d9

Please sign in to comment.