fix static build error due to duplicate MD5 functions #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we link to -lcrypto unconditionally, we have to define HAVE_OPENSSL unconditionally as well. closes #254
|
Please discuss this on john-dev before we commit it. I'm not sure of possible consequences. |
only when this macro is defined, the array output8x is available, which the asm unconditionally used. this leads to a build error when static linking, but not when dynamic linking since the functions in the asm file are not being used.
|
added a commit. |
|
hmm while the 2nd commit is technically correct, it doesn't help me since NT_X86_64 is defined. |
|
ok, seems -fwhole-program is fundamentally incompatible with asm. |
|
d0571a0 is supposed to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we link to -lcrypto unconditionally, we have to define
HAVE_OPENSSL unconditionally as well.
closes #254