Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sips uri (with explicit port number) #86

Merged
merged 2 commits into from Sep 14, 2012

Conversation

nieluj
Copy link

@nieluj nieluj commented Sep 13, 2012

This patch adds support for sips uri when calculating the salt value for SIP Digest authentication.

@magnumripper
Copy link
Member

Thanks! Did you change the input format, though? In that case we'd need to fix sipdump2john.py too, before I merge this. Or am I just confused?

@nieluj
Copy link
Author

nieluj commented Sep 14, 2012

indeed, the script sipdump2john.py needed to be modified to reflect the changes in sip_fmt_plug.c. By the way, I fixed a bug introduced since 1.7.9-jumbo6 : in the latest version I cloned, the salt value was a static variable of the get_salt function. The salt value of the current hash was overwritten by the test vectors, hence it was impossible to crack anything (besides the hash from the latest test vector).

I replaced this static variable by a dynamic memory allocation (using mem_calloc_tiny) to fix this behaviour but it may not be the cleaner way to do so (because the salt variable is never freed explicitly, this could cause a memory leak).

magnumripper added a commit that referenced this pull request Sep 14, 2012
add support for sips uri (with explicit port number)
@magnumripper magnumripper merged commit b6becd8 into openwall:magnum-jumbo Sep 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants