Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Named inventories show their names #4

Open
magnus-ISU opened this issue Mar 2, 2022 · 2 comments
Open

Feature request: Named inventories show their names #4

magnus-ISU opened this issue Mar 2, 2022 · 2 comments

Comments

@magnus-ISU
Copy link
Owner

First character over the chest icon, and the whole name when hovering over it.

This may not be feasible to implement on the client, I'm unsure.

@Andrew6rant
Copy link

Andrew6rant commented Mar 3, 2022

It is possible to implement on the client, LiamMCW's fork for version 1.17.1 of this mod actually had that feature. (I'd just temporarily removed it to make porting to 1.18.x easier)

image

I believe the relevant code for this is under SimpleBlockTab.java, but it has been a bit since I've worked on this project. I know for certain that my accesswidener is not proper code, haha

EDIT: Oh my gosh, I completely forgot that I did re-implement this feature (with the acesswidener). It wouldn't be too difficult to make the first character of the name show up all the time, sine the data is already there

@magnus-ISU
Copy link
Owner Author

Interesting. I'm pretty sure I was noticing this not happening on the server I play on, but I did see some code relating to it. I'll look at it further later. Right now I'm working on #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants