New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple multiline messages testcases don't work with --sockets flag #39
Comments
Could you supply an example testcase file that exhibits the problem? |
Yes of course, I will create one. |
The attached testcases.zip contains one pipeline configuration and two test directories. Directory tests1 contains one test file with two test cases. tests1 will run successfully without --sockets, but will fail with --sockets. |
Thanks, I'll have a look as soon as I can. |
Many thanks for your efforts. :) |
@dawi could please you try again with codec I tried to quickly run your tests, but I failed, because you are using a quiet new feature of the grok filter ( |
Ok, it works with At the beginning I wanted to use Anyway, the problem exists with |
@dawi true, but this is not resolvable due to the way, the plugin I suggest to close this issue, as it is working fine with |
Ok, I agree, but it would be good if the readme would be more explicit about this. I am wondering if there is any reason to use |
@dawi currently the readme states, that the codec normally should be one of What else do you have in mind? If you want the readme to be more explicit about this issue, maybe you create a PR. |
@breml Yes, I will think about it. But I find it difficult to decide what make sense and what not, since I am just using logstash only for two weeks now. I am currently wondering if it does make sense to use LFV with any other codec then |
Issuing a moratorium on other codecs is probably a mistake since someone's bound to figure out clever ways to make use of other codecs (possibly custom ones that we don't even know exist). However, warning users that the codec they've configured most likely isn't the best choice would be totally doable. What do you think? |
TL;DR: I think it is save to raise a warning if a user uses a codec other than In my opinion the main issue with the This means, that all the codec, which assume to get the messages already properly separated (e.g. There is an other problem: LFV does not allow to configure the codec plugin, which means, our "application layer protocol" (each message on a line) must be supported by the codec by default. For example, the
So, I do not expect the majority of the codecs to currently work with LFV. |
Thanks for the analysis @breml! I've pushed a commit that adds a warning when select codecs are used. |
I have a problem, testing multiline messages with logstash filter verifier and I am not sure if it is a bug or intended behaviour. Either way, a section in the readme about testing multiline messages could help a lot.
I am using the "json" codec to test multiline messages.
The issue is, that if you use the --sockets flag to speed up the tests you cannot have more than one multiline test case per test file.
In this case you currently have two options:
Is there a reason that it is not possible to have multiple multiline testcases in one file in case you use the --sockets flag?
The text was updated successfully, but these errors were encountered: