Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial 16 - merge-env! with nonexistent dirs #429

Closed
gonewest818 opened this issue Jul 5, 2017 · 2 comments
Closed

tutorial 16 - merge-env! with nonexistent dirs #429

gonewest818 opened this issue Jul 5, 2017 · 2 comments

Comments

@gonewest818
Copy link

In tutorial 16 there’s a note that says it's fine to do a (merge-env! :source-paths dirs) where dirs contains nonexistent paths, because there should be no error. But that doesn't seem to be the case for me.

In the following example I'm just launching a repl and merging in a nonexistent directory named "d":

$ boot repl
nREPL server started on port 61064 on host 127.0.0.1 - nrepl://127.0.0.1:61064
REPL-y 0.3.7, nREPL 0.2.12
Clojure 1.8.0
Java HotSpot(TM) 64-Bit Server VM 1.8.0_112-b16
...
boot.user=> (merge-env! :source-paths #{"d"})

java.nio.file.NoSuchFileException: d

This is boot 2.7.1

In the tutorial this means I can't boot tdd with no arguments after adding the "-t" option because the default value for "-t" includes nonexistent dirs test/clj and test/cljs. I know it's trivial to just pass "-t test/cljc" and so of course that's how I'm proceeding. But the behavior I'm seeing directly contradicts what the tutorial suggests ought to happen.

@GiovanniFerrari
Copy link
Collaborator

GiovanniFerrari commented Jul 13, 2017

You are right. That note is true only until boot version 2.5.5. I will correct the tutorial.
Thanks! :)

@gonewest818
Copy link
Author

Looks like you corrected this in commit 49c1942 so I'm going to mark this closed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants