Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getM() and getJ() - separate inside/outside checks from core functions #608

Closed
4 tasks done
OrtnerMichael opened this issue May 24, 2023 · 2 comments
Closed
4 tasks done

Comments

@OrtnerMichael
Copy link
Member

OrtnerMichael commented May 24, 2023

Core functions are trimmed to performance, the mask generation for inside-outside-edge checks take a lot of time. In most cases users know whether they are inside or outside. One more use of it is to refactor the code to enable the calculation of getM and getJ.

  • can inside-outside checks be separated from core computation ?
  • can they be turned on and off in a practical manner ?
  • Add getM()
  • Add getJ()

Note

in_out is currently an unused option in magnet_trimesh_field

to clarify:

@OrtnerMichael
Copy link
Member Author

@Alexboiboi
Copy link
Member

Reopening this as not addressed. Can still be tracked in #647

@Alexboiboi Alexboiboi reopened this Dec 11, 2023
@Alexboiboi Alexboiboi modified the milestones: Future, Version 5 Dec 11, 2023
@Alexboiboi Alexboiboi changed the title inside - outside - edge checks Add add getM() and getP() - separate inside/outside checks from core functions Dec 14, 2023
@Alexboiboi Alexboiboi changed the title Add add getM() and getP() - separate inside/outside checks from core functions Add add getM() and getJ() - separate inside/outside checks from core functions Dec 15, 2023
@Alexboiboi Alexboiboi changed the title Add add getM() and getJ() - separate inside/outside checks from core functions Add getM() and getJ() - separate inside/outside checks from core functions Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants