Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value of Frogg\Model\Criteria::getSql() must be of the type string, array returned #8

Closed
dreanmer opened this issue Nov 13, 2017 · 0 comments
Closed

Return value of Frogg\Model\Criteria::getSql() must be of the type string, array returned #8

dreanmer opened this issue Nov 13, 2017 · 0 comments
Assignees
@magroski
Labels
enhancement

Comments

@dreanmer
Copy link
Contributor

Fatal error: Uncaught TypeError: Return value of Frogg\Model\Criteria::getSql() must be of the type string, array returned in /var/www/app-tfy-v3/vendor/magroski/frogg/src/Model/Criteria.php on line 93

Model/Criteria::getSql return type declaration is string, but the its returning array... I think it's better just change to type array because sometimes we will need to know what values is bound to the query.
@magroski magroski self-assigned this Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magroski magroski

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magroski @dreanmer