Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the warmup and total training step calculation for multi-device #26

Closed
mahalrs opened this issue Apr 26, 2023 · 0 comments · Fixed by #30
Closed

Fix the warmup and total training step calculation for multi-device #26

mahalrs opened this issue Apr 26, 2023 · 0 comments · Fixed by #30

Comments

@mahalrs
Copy link
Owner

mahalrs commented Apr 26, 2023

Currently we are calculating warmup and total training steps based on data loader length. However, we need to consider the scenario of multi-device training in which case total length will be divided by number of devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix right shifting decoder inputs mahalrs/newsgen
1 participant
@mahalrs