Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work with www, works with urls starting with http or https #36

Open
MeenuDhanoa opened this issue Dec 24, 2020 · 3 comments
Open

Does not work with www, works with urls starting with http or https #36

MeenuDhanoa opened this issue Dec 24, 2020 · 3 comments

Comments

@MeenuDhanoa
Copy link

www.google.com - does not work.
http://google.com - works
https://google.com - works.

Testing on iOS. Am is missing something? Or it is designed to work with only HTTP and HTTPS URLs
@evanb2
Copy link
Contributor

evanb2 commented Jan 6, 2021

I also just ran into this. Trying to figure out if it's a bug or expected behavior.

@evanb2
Copy link
Contributor

evanb2 commented Jan 6, 2021

Looks like the regex that link-preview-js is using under the hood is what is restricting this:
https://gist.github.com/dperini/729294#file-regex-weburl-js-L43

// - protocols have been restricted to ftp, http and https only as requested

@mir1198yusuf
Copy link

mir1198yusuf commented May 20, 2021 •
edited

how can we solve this issue then ? any hints
issue also on android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evanb2 @mir1198yusuf @MeenuDhanoa