Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hasOverlay property #58

Closed
maheshmnj opened this issue Oct 27, 2022 · 2 comments
Closed

Remove hasOverlay property #58

maheshmnj opened this issue Oct 27, 2022 · 2 comments
Labels
fixed The issue is fixed in new release hacktoberfest This issue is eligible for hacktoberfest entry Proposal A detailed proposal for change to Searchfield.

Comments

@maheshmnj
Copy link
Owner

Describe the bug
Now that Searchfield supports positioning the suggestions with an offset and the suggestionDirection, the hasOverlay property is no longer required, This issue tracks a request to remove the overlay property.
@maheshmnj maheshmnj added Proposal A detailed proposal for change to Searchfield. hacktoberfest This issue is eligible for hacktoberfest entry labels Oct 27, 2022
@maheshmnj
Copy link
Owner Author

This should also fix #57

@maheshmnj
Copy link
Owner Author

Closing! As Fixed in 5b6189e

@maheshmnj maheshmnj added the fixed The issue is fixed in new release label Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed The issue is fixed in new release hacktoberfest This issue is eligible for hacktoberfest entry Proposal A detailed proposal for change to Searchfield.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maheshmnj