Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]Clarify alignment of suggestion in docs #90

Closed
udcode opened this issue Jun 15, 2023 · 3 comments
Closed

[Docs]Clarify alignment of suggestion in docs #90

udcode opened this issue Jun 15, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation easy fix should be relatively easy to fix fixed The issue is fixed in new release

Comments

@udcode
Copy link

udcode commented Jun 15, 2023

Is your feature request related to a problem? Please describe.
need to align RTL texts from right to left currently the suggestion is sticked to the left side

Describe the solution you'd like
Add Alignment argument to the searchfield widget

Describe alternatives you've considered

Additional context
Ill add a PR for the solution

@maheshmnj
Copy link
Owner

Hello @udcode, thanks for filing the issue. This is already possible as of today by passing a child property to
SearchFieldListItem e.g see this answer #40 (comment)

 SearchField(
      suggestions: _statesOfIndia
      .map((e) => SearchFieldListItem(e,
          child: Align(
              alignment: Alignment.centerRight,
              child: Text(e,
                  style: TextStyle(color: Colors.red),
              ),
          )
        ).toList(),
...
)

there have been similar issue reports in the past

#66
#40

@maheshmnj maheshmnj added waiting for author waiting for author to respond back with more info in triage Issue is currently being triaged labels Jun 15, 2023
@maheshmnj
Copy link
Owner

So I believe we should just clarify this in the readme/docs with an example and it should resolve.

@maheshmnj maheshmnj added documentation Improvements or additions to documentation easy fix should be relatively easy to fix and removed waiting for author waiting for author to respond back with more info in triage Issue is currently being triaged labels Jun 27, 2023
@maheshmnj maheshmnj changed the title allow choosing alignment for the suggestions list [Docs]Clarify alignment of suggestion in docs Jun 27, 2023
@maheshmnj
Copy link
Owner

Fixed in Release v0.8.4
Thank you for your contribution!

cc: @udcode

@maheshmnj maheshmnj added the fixed The issue is fixed in new release label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation easy fix should be relatively easy to fix fixed The issue is fixed in new release
Projects
None yet
Development

No branches or pull requests

2 participants