Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose save-method of underlying TextFormField #92

Closed
philitell opened this issue Jul 31, 2023 · 4 comments
Closed

Expose save-method of underlying TextFormField #92

philitell opened this issue Jul 31, 2023 · 4 comments
Labels
easy fix should be relatively easy to fix fixed The issue is fixed in new release P3 Low Priority: A bug or a feature request we plan to work on in near future (default) severe: new feature Request for a new capability or a feature

Comments

@philitell
Copy link

It would be really helpful if SearchField had a parameter "void Function(String?)? onSaved". With this method SearchField could be used in complex Forms. An Implementation should be possible by exposing the onSaved-method of the underlying TextFormField inside SearchField.
The method could be usefull when using SearchField inside a Form-widget.

@maheshmnj maheshmnj added the in triage Issue is currently being triaged label Jul 31, 2023
@maheshmnj
Copy link
Owner

maheshmnj commented Jul 31, 2023

Thanks for the feature request @philitell Feel free to file a PR if you are interested and I would be happy to review. I will try to land this anyways probably by end of this week.

expose onSaved: https://api.flutter.dev/flutter/widgets/FormField/onSaved.html

@maheshmnj maheshmnj added severe: new feature Request for a new capability or a feature easy fix should be relatively easy to fix P3 Low Priority: A bug or a feature request we plan to work on in near future (default) and removed in triage Issue is currently being triaged labels Jul 31, 2023
@philitell
Copy link
Author

Thank you @maheshmnj - this would be great.
Same thing could be done for "onTapOutside" method - https://api.flutter.dev/flutter/material/TextField/onTapOutside.html
This would also be very usefull.

@maheshmnj
Copy link
Owner

Same thing could be done for "onTapOutside" method - https://api.flutter.dev/flutter/material/TextField/onTapOutside.html
This would also be very usefull.

@philitell Can you file that as a separate issue so that we can independently track these requests.

@maheshmnj
Copy link
Owner

maheshmnj commented Aug 7, 2023

Fixed in Release v0.8.4
Thank you for your contribution!
cc: @philitell

@maheshmnj maheshmnj added the fixed The issue is fixed in new release label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy fix should be relatively easy to fix fixed The issue is fixed in new release P3 Low Priority: A bug or a feature request we plan to work on in near future (default) severe: new feature Request for a new capability or a feature
Projects
None yet
Development

No branches or pull requests

2 participants