New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ritam #1
Ritam #1
Conversation
Hi Ritam, thank you for making a contribution to this project. Highlights: Concerns: Your pull request is highly appreciated, I will try to sort out the first two concerns but if you could please look upon the third. |
@RitamChakraborty Thank you for your worthwhile contribution :) |
I managed to fix the problem the same way I did in my project and which I had already mentioned you. I still feel like there is a better way to do it. I'm thinking of posting it in StackOverflow hoping to find out a better approach.
Other than that ...
Apart from that, I've few concerns too ...
If if you think the changes are good of accepting then do merge the PR. And also don't hesitate point out any mistakes I made. It'll be greatly appreciated.