Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Add messages do not export as expected #48

Closed
Septikai opened this issue Jun 20, 2022 · 4 comments
Closed

Pin Add messages do not export as expected #48

Septikai opened this issue Jun 20, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Septikai
Copy link

Septikai commented Jun 20, 2022

DiscordChatExporterPy Version

2.2.1

Discord Version

Discord.py 2.0.0a4318+g823d650e (Most recent commit at time of writing)

Bug Description

When creating a transcript with export() or quick_export() (I haven't tested with raw_export()), any messages to show a pin being added will be shown as an empty message from the user pinning the message, replying to the message they pinned, instead of a message stating "USER pinned a message to this channel. See all pinned messages."

Bug Traceback

No console output.

Additional Information

image
image

@Septikai Septikai added the bug Something isn't working label Jun 20, 2022
@Septikai
Copy link
Author

From what I can find, in dpy, the MessageType of pins being added is an enum, MessageType.pins_add, rather than a string as chat-exporter seems to expect here.
image
image

@mahtoid mahtoid self-assigned this Jun 21, 2022
@mahtoid
Copy link
Owner

mahtoid commented Jun 21, 2022

Thank you for the report.

This issue was brought up within the Discord server ~a week ago. I have the solve locally which I can push up to the Repo, although it will probably sit on a dev branch until 2.3 is ready.

I'll keep this issue open until the branch is up.

@mahtoid
Copy link
Owner

mahtoid commented Jul 13, 2022

I forgot to drop a message here. This has been added to the development branch.

You can clone the repository in to your project then checkout that branch if you wish to use it locally until it'll be released.

Please note, I have also updated a bunch of CSS and re-added HTML escaping, so there may be some issues. If you find anything, let me know.

@mahtoid mahtoid closed this as completed Jul 13, 2022
@Septikai
Copy link
Author

Thanks, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants