fix: 馃悰 login middleware redirect #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicol07
approved these changes
Jun 8, 2021
|
Thank you for the PR. As you can see here this is an issue without a fix. Thank you for providing one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found an issue with the login middleware when the forum URL is located in a subpath instead of domain root.
Steps to reproduce:
Flarum location: http://demo.loc/forum
Login with SSO from http://demo.loc
This action will add the following cookie:
flarum_token
** Make sure to not have flarum_session cookie already set
Access http://demo.loc/forum/t/general
You will be redirected to http://demo.loc/t/general
LoginMiddleware.php:40, $request->getUri() returns "http://demo.loc/t/general"
Tracked issue: FSSOE-19