Conversation
ghost
commented
Feb 25, 2016
Thanks for the pull request, and welcome! The MaidSafe team is excited to review your changes, and you should hear from @canndrew (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTOR.md for more information. |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. Cargo.toml, line 10 [r2] (raw file): "Version update to 0.0.4" This message triggers a tag and documentation update.. If you can split the PR in two then it's good to merge and thanks very much for the contributions. Comments from the review on Reviewable.io |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. Cargo.toml, line 10 [r2] (raw file): Comments from the review on Reviewable.io |
r? @dirvine (thanks for the update) Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. Comments from the review on Reviewable.io |
hm, guess i can't amend these. i'll submit two fresh ones |
Go to you too late, you can amend with a push to your branch. Anyway I will wait on the new PR, all you need to is update teh net2 dep, the lib here does not need a version update just yet (as we use the ~) Thx again |
I was curious about the version bump - though crust build would stumble upon two different tiny net2 versions... but that turns out to not be the case - clean build passes just fine. sorry for the fuss. |
No fuss, happy for all contributors to feel at home here, so work away and PR anything you feel helps. The team will give feedback and help out. I suspect a version bump is required for the config_file_handler though to grab those changes for bsd (again just use "Version update to XXX" in the PR with only the changelog updated and the single change in cargo.toml if you want. We will get to it very soon otherwise.. |
Do you think those version bumps would come at home? I'm fixing thing
locally and would probably cover a whole bunch of the projects to work
out a clean OpenBSD build. right now i'm pathcing local cargo paths
where i need maidsafe-related bumps. If you're updating versions
yourself semiregularly, it'd be easier to just let you do the bumps and
i'll be commiting just the fixes. don't want to make much noise out of
it.
|
No worries at all we will get the version bumps done no problem. Be great to be all ok on bsd machines as well so nice work. Thanks again |