Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

Bump net2 dependency to 0.2.22 #40

Closed
wants to merge 2 commits into from
Closed

Bump net2 dependency to 0.2.22 #40

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2016

Review on Reviewable

@maidsafe-highfive
Copy link

Thanks for the pull request, and welcome! The MaidSafe team is excited to review your changes, and you should hear from @canndrew (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTOR.md for more information.

@dirvine
Copy link
Contributor

dirvine commented Feb 25, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


Cargo.toml, line 10 [r2] (raw file):
Can you please split into two PR's. When we update a version we use a special format for commit messages (and PR title). This should be (without quotes)

"Version update to 0.0.4"

This message triggers a tag and documentation update.. If you can split the PR in two then it's good to merge and thanks very much for the contributions.


Comments from the review on Reviewable.io

@dirvine
Copy link
Contributor

dirvine commented Feb 25, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


Cargo.toml, line 10 [r2] (raw file):
In fact I am not sure we need a version update here as this will pick up the latest net2, so just a commit to update the net2 version is fine thanks.


Comments from the review on Reviewable.io

@dirvine
Copy link
Contributor

dirvine commented Feb 25, 2016

r? @dirvine (thanks for the update)


Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

@ghost
Copy link
Author

ghost commented Feb 25, 2016

hm, guess i can't amend these. i'll submit two fresh ones

@ghost ghost closed this Feb 25, 2016
@dirvine
Copy link
Contributor

dirvine commented Feb 25, 2016

Go to you too late, you can amend with a push to your branch. Anyway I will wait on the new PR, all you need to is update teh net2 dep, the lib here does not need a version update just yet (as we use the ~)

Thx again

@ghost
Copy link
Author

ghost commented Feb 25, 2016

I was curious about the version bump - though crust build would stumble upon two different tiny net2 versions... but that turns out to not be the case - clean build passes just fine. sorry for the fuss.

@dirvine
Copy link
Contributor

dirvine commented Feb 25, 2016

No fuss, happy for all contributors to feel at home here, so work away and PR anything you feel helps. The team will give feedback and help out. I suspect a version bump is required for the config_file_handler though to grab those changes for bsd (again just use "Version update to XXX" in the PR with only the changelog updated and the single change in cargo.toml if you want. We will get to it very soon otherwise..

@ghost
Copy link
Author

ghost commented Feb 25, 2016 via email

@dirvine
Copy link
Contributor

dirvine commented Feb 25, 2016

No worries at all we will get the version bumps done no problem. Be great to be all ok on bsd machines as well so nice work. Thanks again

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants