Add API to respond to bidirectional stream when getting next message from connection. #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new method `next_with_stream` to `ConnectionIncoming` in order for users to respond to a bidirectional stream.
dirvine
approved these changes
Feb 25, 2022
|
also @hansonkd we follow conventional commits for commit messages to auto generate changelogs for release. So if you could reformat your messages to follow that it would be great 🙇 (eg: |
|
This has been superseded by #382 where I've tidied up the commit history and addressed the clippy issues w/r/t type complexity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was building bindings for qp2p for Elixir and came across a case where i needed to not only accept the next message from a bidirectional stream, but also reply to it. I couldn't figure out a way with the current API to do this without having some type of correlation prefix on the message.
This PR adds a new method
next_with_streamtoConnectionIncomingin order for users to respond to a bidirectional stream.If you can accomplish this without these changes in the current API or if you have suggestions, please let me know!