Skip to content
This repository has been archived by the owner on Jun 25, 2021. It is now read-only.

Routing 0.1.62 Id type change causes problem #336

Closed
ustulation opened this issue Jun 11, 2015 · 2 comments
Closed

Routing 0.1.62 Id type change causes problem #336

ustulation opened this issue Jun 11, 2015 · 2 comments
Labels

Comments

@ustulation
Copy link
Contributor

think with the present code client will not be able to work with the new Id thing in routing.
maidsafe_client requires this to be present in the session packet (along with mpid groups) and also to encrypt/decrypt DirectoryListings etc.

It contacts maidsafe-types for that

maidsafe_types does the random symmetric and asymmetric key-pair generations

maidsafe-types has no provision to construct it from given keys - it is who generates it - see:
https://github.com/maidsafe/maidsafe_types/blob/master/src/id/revocation_id_type.rs#L67
for example

And that is how i think it should be - generation of secure keys in types library so that there is one place to go to if someone wants to audit/tinker it and also fits with the paradigm of maidsafe-types crate itself.

routing should not be the one generating keys - it should accept it in a package (like clientid stuff previously) and then do what ever it wants.

Anyway - unless types crate is changed it will break client as of now.

@ghost
Copy link

ghost commented Jun 11, 2015

PR for this issue at #337.

@benjaminbollen
Copy link

maidsafe_client can use the new constructor "with_keys" to construct routing::types::Id to pass into the constructor of routing::routing_client

benjaminbollen pushed a commit that referenced this issue Jun 11, 2015
Add with_keys constructor to Id type. Fixes #336.
maqi pushed a commit to maqi/routing that referenced this issue Oct 13, 2015
maqi pushed a commit to maqi/routing that referenced this issue Oct 6, 2016
Updates incorporating routing changes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants