This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
Patch for Vault Handle Put behaviour; #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send back put response to Client; on FailedToStoreData from ManagedNode with different data, apply patch
|
r? @inetic (maidsafe_highfive has picked a reviewer for you, use r? to override) |
|
r? @dirvine |
|
successfully confirmed consistent behaviour for routing example with this patch; should fix PutResponse on REply to actual client even in big networks -- not tested on big enough network to confirm |
|
Also successfully passes the self_authentication example; conclusion: this PR patches routing to ensure that Vaults Safecoin measurement is not explicitly broken; we can only explicitly test the safecoin farming rate after the payload-issue is resolved in Vaults resolves #423 |
|
Reviewed 1 of 1 files at r2. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
dirvine
added a commit
that referenced
this pull request
Jun 25, 2015
…edToStoreData Patch for Vault Handle Put behaviour;
maqi
pushed a commit
to maqi/routing
that referenced
this pull request
Oct 6, 2016
Updated installers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send back put response to Client;
on FailedToStoreData from ManagedNode with different data, apply patch