Skip to content
This repository has been archived by the owner on Jun 25, 2021. It is now read-only.

Act on churn #426

Merged
merged 6 commits into from
Jun 26, 2015
Merged

Act on churn #426

merged 6 commits into from
Jun 26, 2015

Conversation

benjaminbollen
Copy link

Review on Reviewable

@maidsafe-highfive
Copy link

r? @inetic

(maidsafe_highfive has picked a reviewer for you, use r? to override)

@benjaminbollen
Copy link
Author

running local network tests

@benjaminbollen benjaminbollen changed the title Act on churn WIP Act on churn Jun 26, 2015
improve refresh routing table
reflect own group
cache on connect_response
handle_find_group_response
@benjaminbollen
Copy link
Author

also addresses #427

@benjaminbollen benjaminbollen changed the title WIP Act on churn Act on churn Jun 26, 2015
@benjaminbollen
Copy link
Author

r? @dirvine

works really well; stopping work because I started to pile up several clean up issues in one commit;

the clean up work was provoked by the need for efficient traffic if we activate churn; the network should be much more lean with these cleanups already

@maidsafe-highfive maidsafe-highfive assigned dirvine and unassigned inetic Jun 26, 2015
@dirvine
Copy link
Member

dirvine commented Jun 26, 2015

Reviewed 1 of 3 files at r1, 1 of 3 files at r2.
Review status: 2 of 4 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


src/routing_membrane.rs, line 624 [r2] (raw file):
Should we should use lru cache for this rather than arbitrary timer


Comments from the review on Reviewable.io

@dirvine
Copy link
Member

dirvine commented Jun 26, 2015

Reviewed 2 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


Comments from the review on Reviewable.io

dirvine added a commit that referenced this pull request Jun 26, 2015
@dirvine dirvine merged commit eb79898 into maidsafe:master Jun 26, 2015
@benjaminbollen benjaminbollen deleted the act_on_churn branch August 14, 2015 11:28
maqi pushed a commit to maqi/routing that referenced this pull request Oct 6, 2016
enable unit tests using mock_routing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants