Skip to content
This repository has been archived by the owner on Jun 25, 2021. It is now read-only.

Routing Refactor to channels and core #557

Merged
merged 90 commits into from
Aug 7, 2015
Merged

Routing Refactor to channels and core #557

merged 90 commits into from
Aug 7, 2015

Conversation

benjaminbollen
Copy link

Full refactor of routing:

  1. replace interface with channel architecture
  2. invert hierarchy: vault/client now owns Routing; where before routing wrapped around vault and client was left dangling
  3. simplify handlers, anything Routing does not act on is passed to the event channel
  4. unify routing node
  5. provide a clonable interface to routing_node

Review on Reviewable

Benjamin Bollen and others added 30 commits July 31, 2015 17:17
Initial start to RoutingNode and RoutingHandler
6ef3478
simplify RoutingMessage to Authority routing
f21fb0f
RoutingHandler::new (initial)
8259466
copy of active methods to RoutingNode
56453df
Remove NameAndTypeId
f384690
update authority
7b15221
basic event type
09b8d1d
Event::Refresh
9656070
label event
c2d3cc8
claimant to SignedMessage
1b310da
Document (and compiles) Event
98f26f6
update documentation of event::refresh::payloads
e8f607f
update dependencies of event.rs
42f9c0a 
Signed-off-by: Benjamin Bollen <benjamin.bollen@maidsafe.net>
remove unknown and managed_client from Authority
4c26663
remove NameAndIdType
1ee86c4
authority::get_location
2b0f5eb
compilation fix for SignedMessage
912767b
Event::Terminated for clean shutdown
7928765
Optional signature for Client or ManagedNode
0e3fc20
Action for internal channel
c98bc48
remove from compilation
6d46cf6
@inetic
WIP: Moves handlers from the old membrane to the new node
574b23e
@inetic
Removes implementation of all the handlers
c4cd72b
@inetic
Removes more handlers
fdb2270
@inetic
Fixes and removes some old functions from RoutingMessage
f411088
@inetic
Fixing compilation issues in authority.rs
4203181 
And commenting out code in RoutingNode, RoutingMembrane and RoutingClient.
Merge pull request #5 from inetic/channel-refactor
80b660f 
WIP: Moves handlers from the old membrane to the new node
rename new routing_node to routing_identity
4291071
updates to construction of routing_handler
dc110d3
change compilation include
f21e41c
@benjaminbollen benjaminbollen mentioned this pull request Aug 7, 2015
Closed
Benjamin Bollen and others added 19 commits August 7, 2015 10:57
Merge remote-tracking branch 'upstream/master' into RoutingCore
26d52e0
core::lookup_name
fab6891
fresh start for Send functions
9af0f53
@inetic
Check that to_authority == our authority
e9c1dc2
@inetic
Adds SignedMessage::new_from_token fn
41d9da9
@inetic
Pass original request to user in Event::Response
d31a9d0
Merge pull request #10 from inetic/channel-refactor
68479e2 
Channel refactor
@inetic
Adds 'name' fn to DataRequest
b38e467
update to routing API
910f243
@inetic
Fixes our_authority for ExternalRequest::Get case
8bd5d10
Merge remote-tracking branch 'david/master' into RoutingCore
5d32728 
Conflicts:
	src/messages.rs
Merge remote-tracking branch 'peter/channel-refactor' into RoutingCore
a74815d
@inetic
Removes ErrorReturn structure
8674e27
small compilation fix
450829e
Merge remote-tracking branch 'peter/channel-refactor' into RoutingCore
7687bcf
Revert "small compilation fix"
f805951 
This reverts commit 450829e.
Routing API
8f3facb
documentation on stop
5e918e1
make Refresh an internal request
6af9a05
@benjaminbollen benjaminbollen changed the title WIP Routing core Routing Refactor to channels and core Aug 7, 2015
@benjaminbollen
Copy link
Author

r? @dirvine feel free to merge :)
looks good to me

@maidsafe-highfive maidsafe-highfive assigned dirvine and unassigned inetic Aug 7, 2015
dirvine added a commit that referenced this pull request Aug 7, 2015
@dirvine
Merge pull request #557 from benjaminbollen/RoutingCore
7a16bc8 
Routing Refactor to channels and core
@dirvine dirvine merged commit 7a16bc8 into maidsafe:master Aug 7, 2015
@benjaminbollen benjaminbollen deleted the RoutingCore branch August 14, 2015 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dirvine dirvine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjaminbollen @maidsafe-highfive @inetic @dirvine