This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
Pruning, also, cleaning up NameType traits a bit #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dirvine
commented
Aug 9, 2015
dirvine
commented
|
r? @inetic (maidsafe_highfive has picked a reviewer for you, use r? to override) |
| @@ -22,7 +22,6 @@ use NameType; | |||
| // Note: name field is initially same as original_name, this should be later overwritten by | |||
| // relocated name provided by the network using assign_relocated_name method | |||
| // TODO (ben 2015-04-01) : implement order based on name | |||
| #[derive(Clone)] | |||
There was a problem hiding this comment.
I was planning on cloning the Id from the initial Routing object into the Routing core, as vaults acting on Routing need to sign messages as the RoutingNode; alternatively we need to have a separate Action:: that takes the elements of a message, but not a fully SignedMessage, and then finish construction in RoutingNode
|
looks good to me |
|
@dirvine CI check are failing, is that expected? |
inetic
pushed a commit
that referenced
this pull request
Aug 10, 2015
Pruning, also, cleaning up NameType traits a bit
maqi
pushed a commit
to maqi/routing
that referenced
this pull request
Nov 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.