This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
Example refactoring #571
Merged
Example refactoring #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change IAm to Hello
|
(maidsafe_highfive has picked a reviewer for you, use r? to override) |
| use std::io; | ||
| use std::net::SocketAddr; | ||
| use std::str::FromStr; | ||
| use std::sync::{Arc, Mutex}; | ||
| use std::sync::{Arc, Mutex, mpsc}; |
There was a problem hiding this comment.
Can we now do without an Arc / Mutex ?
| } | ||
| impl Client { | ||
| fn new(_bootstrap_peers: Vec<Endpoint>) -> Result<Client, RoutingError> { | ||
| let (routing_sender, routing_receiver) = mpsc::channel::<Event>(); |
There was a problem hiding this comment.
just a style issue to consider: naming a channel WHAT_sender, and WHAT_receiver is more clear than WHO_sender/_receiver, as it feels to me less clear what the direction of the channel is
Signed-off-by: Benjamin Bollen <benjamin.bollen@maidsafe.net>
| @@ -20,9 +20,9 @@ use public_id::PublicId; | |||
| use types::Address; | |||
There was a problem hiding this comment.
We should rename the module / file here I think
maqi
added a commit
to maqi/routing
that referenced
this pull request
Nov 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the new Routing API