This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
use SignedMessage::Signature as FilterType for filtering messages #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @inetic (maidsafe_highfive has picked a reviewer for you, use r? to override) |
|
added a TODO note to discuss at a later point the options for a user to explicitly send out multiple "identical" requests for eg increasing/decreasing a network based reference counter |
|
this removes message_id |
inetic
pushed a commit
that referenced
this pull request
Aug 12, 2015
use SignedMessage::Signature as FilterType for filtering messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Signature in the SignedMessage is already the hash of all fields, including claimant and RoutingMessage, making it a unique identifier for detecting duplicate versions of the same message without additional overhead