Accumulator #576
Accumulator #576
Conversation
inetic
commented
Aug 12, 2015
inetic
commented
|
(maidsafe_highfive has picked a reviewer for you, use r? to override) |
|
looks good ! great that we can indeed consider a general RoutingMessage accumulator ! |
|
👍 , nice one @inetic |
| @@ -348,6 +352,11 @@ impl RoutingNode { | |||
| return Err(RoutingError::BadAuthority); | |||
| } | |||
|
|
|||
| let (message, opt_token) = match self.accumulate(message_wrap) { | |||
There was a problem hiding this comment.
Can we exclude InternalResponse::CacheNetworkName from this accumulator; we are currently not using FindGroup/Response::FindGroup so no need to mind that; for now just don't accumulate CacheNetworkName Responses
There was a problem hiding this comment.
Sorry you deal with this in fn accumulate; ignore my comment !
There was a problem hiding this comment.
Sorry no :), this function does not exclude this one message type; can we patch this here?
|
looks good but can you apply the patch to exclude InternalResponse::CacheNetworkName from the accumulator (it will never resolve as every message is seen as different, as it includes the close group) |
|
looks good to me |
