Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

FfiResult struct may be misdeclared #339

Open
hunterlester opened this issue Dec 29, 2018 · 0 comments
Open

FfiResult struct may be misdeclared #339

hunterlester opened this issue Dec 29, 2018 · 0 comments
Labels
bug
Projects
Upcoming release ('master' branch)
Milestone
next

Comments

@hunterlester
Copy link
Contributor

hunterlester commented Dec 29, 2018 •
edited

Could be wrong about this, also not causing any bugs so far as we typically read errors from a third response pointer provided to FFI error callbacks, instead of reading from FffiResult pointer.

See definition in ffi_utils compared to our declaration.

error_description should be description?
Type definition should be CString instead of 'string'?
@hunterlester hunterlester added this to Needs triage in Upcoming release ('master' branch) via automation Dec 29, 2018
@hunterlester hunterlester added this to the next milestone Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
Upcoming release ('master' branch)
  
Needs triage
Milestone
next
Development

No branches or pull requests
1 participant
@hunterlester