This repository has been archived by the owner on Jan 7, 2020. It is now read-only.
Switch XorNames from ref-array to JS Array #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were leaking out ref-array objects here, but that caused troubles when they were used at other parts of the API. Namely if they were serialised without being converted. In order to make things easier we are now always copying them into a JS Array before returning them in the API call and are copying back if they are given as such.
Internally we are using ref-array structs when dealing with data_map_names and since the latest change this has been a JS array instead. This checks for that when the (nfs) File Object is created and converts it into the proper ref-array type again.
gnunicorn
force-pushed
the
xor-actual-array
branch
from
760383a
to
18642a6
Compare
hitman401
approved these changes
Apr 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix the tests that break that.