Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

feat/MutableData: adapt Private MutableData binding function to latest safe_app #74

Conversation

bochaco
Copy link
Contributor

@bochaco bochaco commented May 26, 2017

Latest safe_app expects the secret key and nonce for creating a private MutableData.

Copy link
Contributor

@hitman401 hitman401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The network state callback is updated in the safe_licent_libs PR. app_registered and app_unregistered functions return FFIResult instead of i32

…unctions.

refactor/Remove all FFI error mapping to names/messages and use the messages as reported by safe_client_libs in FFI result.
@bochaco
Copy link
Contributor Author

bochaco commented May 29, 2017

@krishnaIndia , I took care of your requested changes in relation to the FFIResult for app_registered and app_unregistered.

@coveralls
Copy link

Coverage Status

Coverage decreased (-53.9%) to 32.274% when pulling 6667c6f on bochaco:changes-to-private-md-creation-function into 7d61b54 on maidsafe:master.

@bochaco bochaco changed the title [WIP] feat/MutableData: adapt Private MutableData binding function to latest safe_app feat/MutableData: adapt Private MutableData binding function to latest safe_app May 31, 2017
@coveralls
Copy link

coveralls commented Jun 1, 2017

Coverage Status

Coverage decreased (-53.9%) to 32.274% when pulling 1885805 on bochaco:changes-to-private-md-creation-function into 7d61b54 on maidsafe:master.

@coveralls
Copy link

coveralls commented Jun 1, 2017

Coverage Status

Coverage decreased (-2.2%) to 83.932% when pulling f381626 on bochaco:changes-to-private-md-creation-function into 7d61b54 on maidsafe:master.

@hitman401 hitman401 merged commit 9ddf844 into maidsafe-archive:master Jun 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants