Skip to content

Commit

Permalink
fix(windows): fix addTab End setting ActiveTab to null
Browse files Browse the repository at this point in the history
  • Loading branch information
manavbp authored and joshuef committed Jun 18, 2019
1 parent a6e7423 commit 6421206
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 6 additions & 0 deletions __tests__/reducers/windows.spec.ts
Expand Up @@ -264,6 +264,7 @@ describe( 'windows reducer', () => {
openWindows: {
[firstWindowId]: {
...basicWindow,
activeTab: tabId,
tabs: [tabId]
}
},
Expand Down Expand Up @@ -291,6 +292,7 @@ describe( 'windows reducer', () => {
openWindows: {
[firstWindowId]: {
...basicWindow,
activeTab: tabId,
tabs: [tabId, tabId1]
}
},
Expand All @@ -307,6 +309,7 @@ describe( 'windows reducer', () => {
openWindows: {
[firstWindowId]: {
...basicWindow,
activeTab: tabId1,
tabs: [tabId, tabId1]
},
[secondWindowId]: {
Expand Down Expand Up @@ -342,6 +345,7 @@ describe( 'windows reducer', () => {
openWindows: {
[firstWindowId]: {
...basicWindow,
activeTab: tabId1,
tabs: [tabId, tabId1]
},
[secondWindowId]: {
Expand All @@ -366,6 +370,7 @@ describe( 'windows reducer', () => {
openWindows: {
[firstWindowId]: {
...basicWindow,
activeTab: tabId1,
tabs: [tabId, tabId1]
},
[secondWindowId]: {
Expand Down Expand Up @@ -401,6 +406,7 @@ describe( 'windows reducer', () => {
openWindows: {
[firstWindowId]: {
...basicWindow,
activeTab: tabId1,
tabs: [tabId, tabId1, tabId3]
},
[secondWindowId]: {
Expand Down
1 change: 0 additions & 1 deletion app/reducers/windows.ts
Expand Up @@ -67,7 +67,6 @@ const addTabEnd = ( state, tab ) => {

const newWindow = {
...openWindows[targetWindow],
activeTab: null,
ui: {
settingsMenuIsVisible: false
},
Expand Down

0 comments on commit 6421206

Please sign in to comment.