Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permissions for public register creation #698

Merged
merged 1 commit into from Sep 4, 2023
Merged

Conversation

loziniak
Copy link
Contributor

@loziniak loziniak commented Sep 4, 2023

I've noticed ::create_online() and ::create_public_online() were exactly the same :-)

@reviewpad reviewpad bot requested a review from grumbach September 4, 2023 05:32
@reviewpad
Copy link

reviewpad bot commented Sep 4, 2023

Thank you @loziniak for this first contribution!

@reviewpad reviewpad bot added Small Pull request is small waiting-for-review labels Sep 4, 2023
@reviewpad
Copy link

reviewpad bot commented Sep 4, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'fix permissions for public register creation' (5f581b1)
  • Unconventional title detected: 'fix permissions for public register creation' expecting colon (':') character, got ' ' character: col=03

@joshuef
Copy link
Contributor

joshuef commented Sep 4, 2023

@loziniak can you run cargo fmt on the changes and git commit --amend 🙇 . Changes themselves are fine, but the formatting is tripping up CI.

And thanks for the catch! 🙇

@loziniak
Copy link
Contributor Author

loziniak commented Sep 4, 2023

Done. I was misled by the fact that the formatting in create_online is exactly the same :-)

@joshuef
Copy link
Contributor

joshuef commented Sep 4, 2023

thanks @loziniak ! 🙇

@joshuef joshuef added this pull request to the merge queue Sep 4, 2023
Merged via the queue into maidsafe:main with commit 28f8964 Sep 4, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants