Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

Implement keystore and add tests for it #16

Merged
merged 10 commits into from
May 26, 2015
Merged

Implement keystore and add tests for it #16

merged 10 commits into from
May 26, 2015

Conversation

inetic
Copy link
Contributor

@inetic inetic commented May 25, 2015

@maidsafe-highfive
Copy link

r? @benjaminbollen

(maidsafe_highfive has picked a reviewer for you, use r? to override)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.42%) to 99.38% when pulling 5800943 on inetic:MAID-1022-implement-keystore into 06ae55b on maidsafe:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.42%) to 99.38% when pulling 5800943 on inetic:MAID-1022-implement-keystore into 06ae55b on maidsafe:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.42%) to 99.38% when pulling 05e347f on inetic:MAID-1022-implement-keystore into 06ae55b on maidsafe:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.42%) to 99.38% when pulling 05e347f on inetic:MAID-1022-implement-keystore into 06ae55b on maidsafe:master.

@benjaminbollen
Copy link
Contributor

Nice work. I appreciate the fact that you check the self_signing. Also that you keep a set of the senders. That will be useful later on, when we want to derank nodes that provided false information.

benjaminbollen pushed a commit that referenced this pull request May 26, 2015
Implement keystore and add tests for it
@benjaminbollen benjaminbollen merged commit d9448e9 into maidsafe-archive:master May 26, 2015
@dirvine
Copy link
Contributor

dirvine commented May 26, 2015

For sure, also when a node asks to Get something that is not there (especially StructuredData) it would be nice to filter the node for 10/20 minutes.

@dirvine
Copy link
Contributor

dirvine commented May 26, 2015

What I mean is that if vaults or any upper layer returned a RoutingError::BanNode It then allows routing to make decisions on behaviour but also upper layers as well. Therefor we have routing rank etc. and vault rank (in our case) which is very neat.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants