This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Implement keystore and add tests for it #16
Merged
benjaminbollen
merged 10 commits into
maidsafe-archive:master
from
inetic:MAID-1022-implement-keystore
May 26, 2015
Merged
Implement keystore and add tests for it #16
benjaminbollen
merged 10 commits into
maidsafe-archive:master
from
inetic:MAID-1022-implement-keystore
May 26, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs adjustments in the lru_cache crate
It now returns a Vec instead of Option.
(maidsafe_highfive has picked a reviewer for you, use r? to override) |
Nice work. I appreciate the fact that you check the self_signing. Also that you keep a set of the senders. That will be useful later on, when we want to derank nodes that provided false information. |
benjaminbollen
pushed a commit
that referenced
this pull request
May 26, 2015
Implement keystore and add tests for it
For sure, also when a node asks to Get something that is not there (especially StructuredData) it would be nice to filter the node for 10/20 minutes. |
What I mean is that if vaults or any upper layer returned a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement: maid 1022
test: maid 1023