This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
NeighbourInfo cleanup and send ParsecPoke to all members #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Viv-Rajkumar
commented
Apr 1, 2019
Viv-Rajkumar
commented
- Remove old compatible neighbour pfx not restricted to a strict parent/child prefix in Chain on updating neighbour_infos.
- Send ParsecPoke to all section members to prevent connection timeouts triggering invalid Offline votes while JoiningNode is getting established. This prevents invalid test failures with unaccumulated Parsec::Remove blocks.
…arent/child prefix in Chain on updating neighbour_infos. tmp: Send ParsecPoke to all section members to prevent connection timeouts triggering invalid Offline votes while JoiningNode is getting established. This prevents invalid test failures with unaccumulated Parsec::Remove blocks.
Viv-Rajkumar
force-pushed
the
nei_infos_patch
branch
from
d194bd9
to
3f6b946
Compare
afck
approved these changes
Apr 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.