feat: introduce testnet-id parameter #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in the comment, the change of workspace is necessary for the deletion of the workspace that was created for this particular run.
Give control of the testnet ID to the caller of the action. This means the caller can retrieve debugging information from S3 based on the name of the testnet ID, which they have control over, and so information doesn't need to be passed out of the custom action. This removes the need for copying debugging information to the system-wide location, which was not very useful anyway, because it's only accessible within the same job, which isn't very useful.
joshuef
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
471f976 fix: reintroduce workspace selection
As explained in the comment, the change of workspace is necessary for the deletion of the workspace
that was created for this particular run.
00479d2 feat: introduce testnet-id parameter
Give control of the testnet ID to the caller of the action.
This means the caller can retrieve debugging information from S3 based on the name of the testnet
ID, which they have control over, and so information doesn't need to be passed out of the custom
action.
This removes the need for copying debugging information to the system-wide location, which was not
very useful anyway, because it's only accessible within the same job, which isn't very useful.